The controller Debate is funny, I just can't seem to find any company that will do a controller right, but I still maintain that the PS2 has the best of the bunch over all.
The GC: Too few buttons, Fairly well designed, though not every button is placed in a useful manner. It's also too small for large hands.
Xbox: Normal controller has a perfect size for adult hands, but has horrible button placement (diagonal diamond?) and several of the buttons aren't that useful for twitch reflex games (fighting games etc) Thos would be the B&W buttons, and the analog triggers. (The Triggers are great for driving though.)
The S-Controller improves the button layout of the main 4, but makes the B&W buttons useless, as well as the select button. It's also getting a little on the small side.
PS2: Small, but open design makes it useable to all hand sizes. Perfect button layout, dual analog with more buttons than any other making it great for action games. The lack of Analog triggers hurts driving Sims, but I forgive that because I use a wheel.
There is a company called Ascii in Japan that makes perfect controllers though (especially for fighting fans) The can be imported on sites like
www.tronixweb.com